reivew of README content#73
Conversation
|
Thanks, readme could always be improved.
The partitions.csv is needed. You will get a validation error if it is not correct.
I think it is up-to-date. Please remove the batches on top, two are useless anyway and the 3rd is not really helping. |
Removed GitHub badges from README and added important documentation about the mandatory partitions_zb.csv file that must be included in ESP32 configurations when using this component. The new section explains that this file is required for proper Zigbee operations and can be found in the component directory, defining the memory partitions needed for Zigbee functionality.
|
Thanks! I've updated removing the badges and referring to the csv file! Let me know if you find anything else that can be improved! |
luar123
left a comment
There was a problem hiding this comment.
Overall looks nice, just some information got lost. Can you include the missing pieces?
|
I think overall this looks fine. |
… remove partition table note - Reorganized README with table of contents - Formatted features, limitations, and configuration sections - Removed partition table requirement (no longer needed) - Kept all recent changes from luar123#85
Done, let me know if you need any more changes. Thanks! |
Hello!
I was looking for something for using ESP Home with zigbee, I found out this repository which was kinda easy to include and build with it, but it was kinda of a exploration of the readme and the example. I'd like to submit a pull request to enhance the readability of the README while preserving all the original information (to the best of my understanding).
Before proceeding, I have a few questions to ensure the changes align with the project's goals:
Thank you for your excellent work on this project! I was also curious—did you consider submitting a feature proposal to the original ESP Home project for Zigbee integration?
Cheers