Conversation
|
@qrsikno2 I don't see you adding luahid in here.. https://github.com/luainkernel/lunatik/blob/master/bin/lunatik#L10 |
|
|
||
| #include <lunatik.h> | ||
|
|
||
| #include "luanetfilter.h" |
There was a problem hiding this comment.
That is because i need to use the good macro developed by sheharyaar
lunatik_setstring(L, 1, user_driver, name, NAME_MAX);in Line 88
There was a problem hiding this comment.
so we should move this macro to lunatik.h
fixed |
| } | ||
| lunatik_setruntime(L, hid, hid); | ||
| lunatik_getobject(hid->runtime); | ||
| // pass |
There was a problem hiding this comment.
What does pass mean here? Btw, please don't use cpp comment style..
|
|
||
| //configure the driver's properties & callbacks | ||
| struct hid_driver *user_driver = &(hid->driver); | ||
| user_driver -> name = lunatik_checkalloc(L, NAME_MAX); |
There was a problem hiding this comment.
Please mind our code style.. when in doubt, use Linux's code style.. no space around ->
| struct hid_driver driver; | ||
| } luahid_t; | ||
|
|
||
| //kernel codes |
There was a problem hiding this comment.
Always refer to the original if you are borrowing something
lneto
force-pushed
the
master
branch
2 times, most recently
from
17ac113 to
925bfd9
Compare
2 participants
copy from
hid-genericto lunatik.