Skip to content

Shellcheck fixes #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavierba wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Shellcheck fixes #99

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
72670aa
SC2236 (style): Use -n instead of ! -z
xavierba Jan 31, 2024
cf5701c
SC2006 (style): Use $(...) notation instead of legacy backticks `...`
xavierba Jan 31, 2024
e32951b
SC2086 (info): Double quote to prevent globbing and word splitting
xavierba Jan 31, 2024
d0d95a1
SC2166 (warning): Prefer [ p ] || [ q ] as [ p -o q ] is not well def…
xavierba Jan 31, 2024
ac971b3
SC2059 (info): Don't use variables in the printf format string. Use p…
xavierba Feb 1, 2024
588889a
SC2126 (style): Consider using 'grep -c' instead of 'grep|wc -l'
xavierba Feb 1, 2024
892d22d
SC2046 (warning): Quote this to prevent word splitting
xavierba Feb 1, 2024
0f61b0b
SC2070 (error): -n doesn't work with unquoted arguments. Quote or use…
xavierba Feb 1, 2024
7eab0ea
SC2219 (style): Instead of 'let expr', prefer (( expr ))
xavierba Feb 7, 2024
6e80ea8
SC2016 (info): Expressions don't expand in single quotes, use double …
xavierba Feb 7, 2024
d8fbe9b
SC2004 (style): $/${} is unnecessary on arithmetic variables
xavierba Feb 7, 2024
7ca2b9b
SC1090 (warning): ShellCheck can't follow non-constant source. Use a …
xavierba Feb 7, 2024
21dab42
SC2034 (warning): OS appears unused. Verify use (or export if used ex…
xavierba Feb 7, 2024
33971dd
SC2115 (warning): Use "${var:?}" to ensure this never expands to /*
xavierba May 11, 2026
7edf3b1
SC2003 (style): expr is antiquated. Consider rewriting this using $((…
xavierba May 11, 2026
cc21f40
SC2268 (style): Avoid x-prefix in comparisons as it no longer serves …
xavierba May 11, 2026
844799c
SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not i…
xavierba May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading