Skip to content

Conversation

@natelust
Copy link
Contributor

@natelust natelust commented Dec 8, 2025

No description provided.

This commit adds a few new tasks which are responsible for making
hips trees from previously generated RGB images stored as numpy
arrays. These tasks run parallel over hips order 8 and hips order 3.
This has a copy of functionality in afw with slight modifications. These
will be added back to afw, but are reproduced here to make it easier
to run from a single branch of pipe_tasks.
input_hips = Input(
doc="Hips pixels at level 8 used to build higher orders",
name="rgb_picture_hips8",
storageClass="NumpyArray",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pickle formatter; is there anything better that we could use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan for this is to use this for now, and later switch to one of the new container classes Jim will be building. As these are mainly just used as intermediates for building the hips output the eventual change over should cause no disruption.


This function takes in an input keyed by tract, with values
corresponding the patches in that tract that overlap the quatum's
healpix value. It assemeble each of these into a single image such
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It assemeble -> It assembles


Parameters
----------
tract_patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type here?


Retruns
-------
output_list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retruns -> Returns. And output_list needs a type.

doc="URI to HiPS base for output.",
optional=False,
)
color_ordering = Field[str](doc="The bands used to construct the input images", optional=False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment on the docstring here and file_extension

# loop over each order, assembling the previous order tiles into
# an array, and writing the image. Resample each image smaller,
# and continue downward in order.
for order in range(7, self.config.min_order - 1, -1):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 is fixed here; does that mean that the dimensionality must be the default healpix8 and not changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants