DM-53622: add provenance to SeparablePipelineExecutor #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #537 +/- ##
==========================================
- Coverage 88.96% 88.96% -0.01%
==========================================
Files 151 153 +2
Lines 20840 20992 +152
Branches 2463 2481 +18
==========================================
+ Hits 18541 18675 +134
- Misses 1720 1731 +11
- Partials 579 586 +7 ☔ View full report in Codecov by Sentry. |
TallJimbo
force-pushed
the
tickets/DM-53622
branch
from
d4510ff to
5ff1552
Compare
This can already do basic partial reads and log/metadata fetches via components. Future versions will need to be usable with the log and task metadata storage classes as well. Tests will be added after we make some tests that actually write provenance QGs.
This means the outputs_put get stuffed into the metadata that's then stuffed into the 'extra' section of the log records, but that's enough for the provenance system to get it.
This should prevent more existence checks in aggregate-graph.
This was a missed opportunity on DM-53174.
All logic/behavior should be identical; this just separates the code that actually writes a provenance QG from the subprocess communication code that runs it in the BPS/QBB-focused aggregator tool.
This does not change any logic/behavior (except for one log message).
TallJimbo
force-pushed
the
tickets/DM-53622
branch
from
5ff1552 to
838a589
Compare
...and tests for the rest of this branch.
TallJimbo
force-pushed
the
tickets/DM-53622
branch
from
838a589 to
240085a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
package-docs builddoc/changes