Skip to content

Conversation

@TallJimbo
Copy link
Member

@TallJimbo TallJimbo commented Dec 17, 2025

Checklist

  • ran Jenkins
  • ran and inspected package-docs build
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.98%. Comparing base (458dba7) to head (a4acbf2).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/pipe/base/log_capture.py 80.95% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   88.96%   88.98%   +0.02%     
==========================================
  Files         151      151              
  Lines       20861    20840      -21     
  Branches     2464     2463       -1     
==========================================
- Hits        18558    18544      -14     
+ Misses       1725     1719       -6     
+ Partials      578      577       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

if ctx.store:
self._ingest_log_records(quantum, log_dataset_name, log_file)
shutil.rmtree(tmpdir, ignore_errors=True)
with TemporaryForIngest(self.full_butler, ref, ingest_on_failure=True) as temporary:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be ingest_on_failure=ctx.store to preserve the existing behavior? Or maybe =False since we don't want to ingest if there's a failure before we write out the logs in the finally block? (e.g. an exception is thrown before we yield, or there's a second exception in the finally block.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have read this before responding to the daf_butler PR; I think this does push me back in the direction of having an ingest method on the context manager. Even though errors in those other places should be extremely rare, I think it'll be cleaner that way.

@TallJimbo TallJimbo merged commit b7b1fac into main Dec 18, 2025
21 of 22 checks passed
@TallJimbo TallJimbo deleted the tickets/DM-53648 branch December 18, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants