-
Notifications
You must be signed in to change notification settings - Fork 11
DM-33034: tools for building Sphinx docs from Pipelines #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2d13499 to
7d9c7b6
Compare
|
#347 has merged. I think that unblocks this ticket to allow it to be rebased on main rather than the temporary branch. |
|
Yes, but there will definitely be conflicts as well as other work to get this branch working again. Might be best to just close the PRs and then delete the temporary base branches. |
7d9c7b6 to
3727608
Compare
|
I dropped the commits from the base branch on the basis that you have already merged things (the expanded pipeline stuff was dropped?) and then the rebase was pretty straightforward once I also dropped all the ButlerURI renaming. |
|
The expanded pipeline stuff morphed dramatically into |
|
I've fixed up all the linting problems. @TallJimbo you may want to confirm it looks right for you before you delete your local branch. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #222 +/- ##
==========================================
- Coverage 82.09% 81.02% -1.08%
==========================================
Files 107 108 +1
Lines 12995 13172 +177
Branches 1678 1692 +14
==========================================
+ Hits 10668 10672 +4
- Misses 1905 2080 +175
+ Partials 422 420 -2 ☔ View full report in Codecov by Sentry. |
9996bd5 to
cdc61bf
Compare
c3d7525 to
2a3260b
Compare
2a3260b to
748e3a3
Compare
748e3a3 to
41a0383
Compare
Checklist
doc/changesThis PR is against a temporary branch, because merging this ticket (but not its review) is blocked by DM-33027. After that lands I'll rebase.
There are two largely mechanical commits here:
80c65ab just moves existing code from
ctrl_mpexec, with only trivial changes to import statements.b014171 is mostly a bulk-rename followup to DM-31723 - I did that here because using
ResourcePathin new code while leavingButlerURIin nearby existing code was getting increasingly awkward.The bulk of the changes are in 2d13499; everything else is just setup.