Skip to content

DM-53442: Update cModel dev/exp size column names #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taranu merged 2 commits into from
Dec 19, 2025
Merged

DM-53442: Update cModel dev/exp size column names #449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c40095
Rename size columns
taranu Dec 3, 2025
810532a
Don't use KDE with <2 points
taranu Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/lsst/analysis/tools/actions/plot/colorColorFitPlot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,14 +290,14 @@ def makePlot(
# Try using a Gaussian KDE to get color bars showing number density. If
# there are not enough points for KDE, use a constant color.
zUsed = np.ones(np.sum(fitPoints))
if len(xyUsed.ravel()) > 0:
if len(xyUsed.ravel()) >= 2:
try:
zUsed = scipy.stats.gaussian_kde(xyUsed)(xyUsed)
except np.linalg.LinAlgError:
pass

zNotUsed = np.ones(np.sum(~fitPoints & goodPoints))
if len(xyNotUsed.ravel()) > 0:
if len(xyNotUsed.ravel()) >= 2:
try:
zNotUsed = scipy.stats.gaussian_kde(xyNotUsed)(xyNotUsed)
except np.linalg.LinAlgError:
Expand Down
20 changes: 13 additions & 7 deletions python/lsst/analysis/tools/atools/genericBuild.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ class MagnitudeTool(ObjectClassTool):

fluxes_default = FluxesDefaultConfig(
bulge_err=FluxConfig(
key_flux="{band}_bdFluxB",
key_flux_error="{band}_bdFluxBErr",
key_flux="{band}_cModel_devFlux",
key_flux_error="{band}_cModel_devFluxErr",
name_flux="CModel Bulge",
name_flux_short="bulge_cModel",
),
Expand All @@ -271,8 +271,8 @@ class MagnitudeTool(ObjectClassTool):
name_flux_short="cModel",
),
disk_err=FluxConfig(
key_flux="{band}_bdFluxD",
key_flux_error="{band}_bdFluxDErr",
key_flux="{band}_cModel_expFlux",
key_flux_error="{band}_cModel_expFluxErr",
name_flux="CModel Disk",
name_flux_short="disk_cModel",
),
Expand Down Expand Up @@ -537,10 +537,16 @@ class SizeTool(ObjectClassTool):
default=True,
)
sizes_default = SizeDefaultConfig(
bulge=SizeConfig(key_size="{band}_bdReB", name_size="CModel Bulge $R_{eff}$", has_moments=False),
disk=SizeConfig(key_size="{band}_bdReD", name_size="CModel Disk $R_{eff}$", has_moments=False),
bulge=SizeConfig(
key_size="{band}_cModel_dev_reff_major", name_size="CModel Bulge $R_{eff}$", has_moments=False
),
disk=SizeConfig(
key_size="{band}_cModel_exp_reff_major", name_size="CModel Disk $R_{eff}$", has_moments=False
),
moments=SizeConfig(key_size="{band}_i{suffix}", name_size="Second moment radius"),
sersic=SizeConfig(key_size="sersic_{suffix}", name_size="Sérsic $R_{eff}$"),
sersic=SizeConfig(
key_size="sersic_reff_major", name_size="Sérsic $R_{eff,major}$", has_moments=False
),
shape_slot=SizeConfig(key_size="shape_{suffix}", name_size="Shape slot radius"),
)
size_type = ChoiceField[str](
Expand Down
Loading