Skip to content

Conversation

@b1quint
Copy link
Member

@b1quint b1quint commented Dec 10, 2025

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@b1quint b1quint force-pushed the tickets/SITCOM-2326 branch from b76fac4 to bb9f3d6 Compare December 10, 2025 16:54
Copy link

@bstalder bstalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analysis is great. as far as the technical description/narrative, we should be more mindful of the distinction between warnings, faults, failures, and errors which have different meanings.

warning: a non-catastrophic event
error: event that cannot be recovered from or allow operation to continue
failure: the lack of success of a command or function call
fault: is the transition between an active state to a safe state after a error/failure

so in this context, for the mtmount, an encoder loss warning means that the system drops this encoder and continues on normally until 3 out of 4 encoders are lost which would cause an error and fault the system.

@ltoribiosc
Copy link
Contributor

@bstalder I have added some more plots to the analysis and changed the names from “falts” to “warnings.” When you can, please check the ticket again.

@b1quint b1quint requested a review from bstalder January 5, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants