Skip to content

fix(tuiapp_v2): Fix tuiapp_v2 selection auto-scroll on Textual 8 #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slowlyo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tuiapp_v2): Fix tuiapp_v2 selection auto-scroll on Textual 8 #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions frontends/tuiapp_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2054,13 +2054,12 @@ def patched(select_widget, mouse_coord, delta_y):
scroll_lines = app.SELECT_AUTO_SCROLL_LINES

candidates = [select_widget]
# Textual 8.2.6 renamed _select_start to _select_state (SelectState.start.container).
select_state = getattr(screen, "_select_state", None)
if select_state is not None:
sw = select_state.start.container
else:
ss = getattr(screen, "_select_start", None)
sw = ss[0] if ss is not None else None
ss = getattr(screen, "_select_start", None)
state = getattr(screen, "_select_state", None)
start = getattr(state, "start", None)
sw = ss[0] if ss is not None else None
if start is not None:
sw = getattr(start, "content_widget", None) or getattr(start, "container", None)
if sw is not None and sw is not select_widget:
candidates.append(sw)

Expand Down