Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/local-dev-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,7 @@ jobs:

- name: check-content
run: |
# download yq
curl https://github.com/mikefarah/yq/releases/download/3.3.0/yq_linux_amd64 -o yq --silent
chmod +x ./yq
./scripts/invalid-docker-ports.sh
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Welcome to your course 🎉
boo

### Getting started

Expand Down
1 change: 1 addition & 0 deletions local_dev/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Important: We should avoid exposing any ports between `20000` and `36384`
# see here for reasons why: https://github.com/logrhythm/boreas/tree/master/documentation/troubleshooting
## trigger boo
version: '3.7'

volumes:
Expand Down
2 changes: 1 addition & 1 deletion scripts/invalid-docker-ports.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ done | sed 's/^"//g' | sed 's/^-//g' | sed '/^$/d' | sed 's/:.*//')
# check range of ports for restricted range
for port in `echo ${exposed_ports} | sed 's/ /\n/g'`
do
#if [ ${port} >= 20000 && ${port} <= 36384 ]; then
#if (( ${port} >= 20000 && ${port} <= 36384 )); then
# make it fail:
if (( ${port} >= 20000 && ${port} <= 41333 )); then
echo "${port} is in a restricted range for Hyper-V"
exit 1
Expand Down