Fix for calculation of widget position#246
Open
ojhp wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a lot of playing around, I believe the offset for a marker/cluster's top-left position should be in the range of -1 to 0 multiplied by the width/height instead of -0.5 to 0.5. (e.g. if the marker is to the top left of the point, the top left of the marker is the whole of the marker's width/height away (-1 offset), if the marker is to the bottom right, the top left of the marker is on the point (0 offset).
I believe this fixes #243 where widgets disappear half way through being scrolled off the bottom or right hand sides of the viewport.
Thanks for the library!