[I2C, sw, hal] Replaced MMIO accesses with autogenerated HAL#545
Merged
Conversation
KinzaQamar
force-pushed
the
i2c_sw_conv_autogen_hal
branch
3 times, most recently
from
272ba69 to
28c6a35
Compare
KinzaQamar
changed the title
KinzaQamar
force-pushed
the
i2c_sw_conv_autogen_hal
branch
2 times, most recently
from
d19a486 to
ee1f1d6
Compare
KinzaQamar
requested review from
elliotb-lowrisc,
engdoreis,
marnovandermaas,
martin-velay and
ziuziakowska
and removed request for
engdoreis
KinzaQamar
force-pushed
the
i2c_sw_conv_autogen_hal
branch
from
ee1f1d6 to
eaa8c05
Compare
This was referenced May 11, 2026
engdoreis
reviewed
May 12, 2026
Collaborator
engdoreis
left a comment
engdoreis
left a comment
There was a problem hiding this comment.
Thanks for getting this done!
I left a few comments regarding coding style. I'm happy approve as soom as the comments are addressed.
KinzaQamar
force-pushed
the
i2c_sw_conv_autogen_hal
branch
2 times, most recently
from
aaf9d98 to
1b73c05
Compare
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
This used to be a part of i2c_init() function and then I took it out from it in lowRISC#521 but forgot to explicitly enable the controller mode here. Signed-off-by: Kinza Qamar <kqzaman@lowrisc.org>
KinzaQamar
force-pushed
the
i2c_sw_conv_autogen_hal
branch
from
1b73c05 to
ac2d20e
Compare
Contributor
Author
|
Thanks @engdoreis for your review. I've addressed your comments and waiting for CI to finish |
engdoreis
approved these changes
May 12, 2026
Collaborator
engdoreis
left a comment
engdoreis
left a comment
There was a problem hiding this comment.
Thanks for the changes.
martin-velay
approved these changes
May 12, 2026
Contributor
martin-velay
left a comment
martin-velay
left a comment
There was a problem hiding this comment.
I am not super familiar with C, but LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing MMIO accesses (
DEV_READandDEV_WRITE) with HAL structs.Close #546