infer correct type for schema.String<T>({ required: false })#69
Merged
zxch3n merged 2 commits intoloro-dev:mainfrom Mar 24, 2026
Merged
Conversation
…e })
When using schema.String<CustomType>({ required: false }) with only one
type parameter, TypeScript would default the second type parameter O to {}
instead of inferring it from the argument. This caused the inferred type
to be CustomType instead of CustomType | undefined.
Fixed by adding function overloads that specifically handle the
{ required: false } case, allowing the options type to be captured
correctly without requiring explicit type parameters.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Anything I can provide to help this land? |
…restore default for overload 3
- Overload 2 now uses `O extends SchemaOptions & { required: false }` instead of
hardcoding the return type to `{ required: false }`, so extra options aren't lost
- Overload 3 restores the original default of `{}` instead of `SchemaOptions`
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using schema.String({ required: false }) with only one type parameter, TypeScript would default the second type parameter O to {} instead of inferring it from the argument. This caused the inferred type to be CustomType instead of CustomType | undefined.
Fixed by adding function overloads that specifically handle the { required: false } case, allowing the options type to be captured correctly without requiring explicit type parameters.
🤖 Generated with Claude Code