stdin input plugin: avoid pushing input before it has been completly …#11
Open
retoo wants to merge 1 commit intologstash-plugins:mainfrom
Open
stdin input plugin: avoid pushing input before it has been completly …#11retoo wants to merge 1 commit intologstash-plugins:mainfrom
retoo wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
…read Should something that we read from sysread() not end with a newline we keep it back until we see the next newline. This mitigates the situation where sysread returns after a certain amount of bytes, regardless if the latest line has terminated.
Author
|
Elastic search: I based my patch on 2.0.1. If there's interest from your side I'll port it to the latest version. |
Author
|
this solves logstash-plugins/logstash-codec-multiline#37 |
Author
|
@karmi I completed the CLA on 28th July, is there a way to retrigger the CLA check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…read
Should something that we read from sysread() not end with a newline
we keep it back until we see the next newline. This mitigates the
situation where sysread returns after a certain amount of bytes,
regardless if the latest line has terminated.