You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current C++ example is unnecessarily complex and slower than a naive implementation. This patch makes the C++ example work the same way as the Nim example by using a vector with 1 byte per bool and using globals.
I'm not Jonathan so I can only provide a datapoint, but for me this is 15% slower than the current CPP implementation on ARM (Cortex-A15). Access to globals is slower and the template-based current implementation passes the visited bitset by value for small graphs (it's a single half-word), including the one used for benchmarking, which is faster than accessing as a global or passing by reference.
I'm not Jonathan so I can only provide a datapoint, but for me this is 15%
slower than the current CPP implementation on ARM (Cortex-A15).
—
Reply to this email directly or view it on GitHub #60 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current C++ example is unnecessarily complex and slower than a naive implementation. This patch makes the C++ example work the same way as the Nim example by using a vector with 1 byte per bool and using globals.