Honor --non-interactive in proxy commands#273
Open
gtsiolis wants to merge 1 commit into
Open
Conversation
gtsiolis
requested review from
anisaoshafi,
carole-lavillonniere and
silv-io
as code owners
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
gtsiolis
force-pushed
the
des-240-honor-non-interactive-in-proxy-commands
branch
from
5181fc9 to
5a27a5c
Compare
gtsiolis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Non-interactive consumers (CI, scripts, agents) need clean, deterministic output.
lstk awsignored--non-interactive— and because the command usesDisableFlagParsing, the flag was also forwarded to theawsbinary, which rejects it as unknown. Image-pull progress likewise produced no plain-mode output (silence during the pull, then a sudden result).Changes
--non-interactivein proxy commands so the spinner is suppressed and the flag isn't passed through toaws.docker pullon a non-TTY), dropping byte-progress ticks so streams stay deterministic.Tests
TestAWSCommandSuppressesSpinnerInNonInteractiveMode(PTY; fails before, passes after) — existing slow/fast spinner tests still pass.TestStripNonInteractiveFlag+ updatedFormatEventLine/PlainSinkparity tests.DES-240
🤖 Generated with Claude Code