Remove license catalog check for version resolution#265
Open
anisaoshafi wants to merge 2 commits into
Open
Conversation
anisaoshafi
force-pushed
the
devx-870-remove-license-catalog-check-for-latest
branch
4 times, most recently
from
b4ba233 to
0da2ed7
Compare
anisaoshafi
requested review from
carole-lavillonniere and
silv-io
as code owners
anisaoshafi
force-pushed
the
devx-870-remove-license-catalog-check-for-latest
branch
from
ed4fad5 to
f01432d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The catalog endpoint has gone stale multiple times and caused outdated versions of localstack to be downloaded.
Now that "latest" refers to the stable monthly release which means pulls from latest are less frequent, we can get rid of the catalog lookup.
Changes
LOCALSTACK_BUILD_VERSIONfrom the image config, and uses that version for the license request.