Support starting the Azure emulator#262
Draft
carole-lavillonniere wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Minimal implementation so that LocalStack Azure emulator (
localstack/localstack-azure-alpha) can be launched.Changes
internal/config:knownImages(localstack/localstack-azure-alpha),emulatorHealthPaths, andContainerPort— soImage()/ProductName()/HealthPath()/ContainerPort()resolve for Azure.SelectableEmulatorTypesso it appears in the first-run emulator picker. Replaced the first-characterSelectionKey()with an explicit unique-key map (a/s/z) —awsandazureboth start with "a", so without this, selecting Azure resolved to AWS.EmulatorType.SelfValidatesLicense()(Snowflake + Azure) and used it instart.go(pre-pull and post-pull validation) andlabel.go. The Azure-alpha container activates its own license against the licensing server; lstk's platformGetLicensehas no catalog entry for it and would otherwise abort the start.Tests
EmulatorTypeForImagefor the Azure image, andSelfValidatesLicensetruth table. Updated existingFindRunningByImageexpectations to include the new repo.TestStartCommandSucceedsForAzure(mirrors the Snowflake start test) launches the Azure emulator and checks the container is running on thelocalstack-azure-alphaimage and serves/_localstack/health.TestFirstRunCanSelectAzureEmulator(PTY, no Docker) confirms Azure is selectable and writestype = "azure".TODO before merging
localstack-azure, see SMF-642Towards FLC-679