Unit tests do not use real $HOME #261
Merged
carole-lavillonniere merged 1 commit intoMay 26, 2026
Merged
Conversation
carole-lavillonniere
changed the title
carole-lavillonniere
changed the title
carole-lavillonniere
changed the title
carole-lavillonniere
requested review from
anisaoshafi and
silv-io
as code owners
anisaoshafi
approved these changes
May 26, 2026
carole-lavillonniere
deleted the
feed-67-tests-perhaps-shouldnt-assume-home-always-exists
branch
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Under Nix's sandboxed build,
$HOMEis set to/homeless-shelter(a deliberately non-existent placeholder), soTestParseDestinationfails because it callsos.UserHomeDir()which does not exist.Changes
homeparameter tosnapshot.ParseDestinationTestParseDestinationto uset.TempDir()as home so it is hermeticTestParseDestinationTildeWithoutHometo test the Nix scenarioTests
make test— all 520 unit tests pass.HOME=/homeless-shelter go test ./internal/snapshot/...passes (and failed before this change).Closes FEED-67