Validate image tag format in config and improve error message#256
Merged
anisaoshafi merged 6 commits intoMay 21, 2026
Merged
Conversation
anisaoshafi
force-pushed
the
devx-859-improve-error-message-for-invalid-image-tags
branch
4 times, most recently
from
837fed2 to
d2c64f5
Compare
anisaoshafi
requested review from
carole-lavillonniere and
silv-io
as code owners
Member
|
Cross-posting relevant decision to redirect this to support zero padding. |
Collaborator
Author
Adjusted according to discussion [1] 🙏🏼 |
gtsiolis
approved these changes
May 20, 2026
Member
gtsiolis
left a comment
gtsiolis
left a comment
There was a problem hiding this comment.
UX LGTM, works as expected. 💯
carole-lavillonniere
approved these changes
May 21, 2026
Collaborator
carole-lavillonniere
left a comment
carole-lavillonniere
left a comment
There was a problem hiding this comment.
👏 good one! Added just one small concern, good to go after it's addressed
| opts.Logger.Error("license server response (HTTP %d): %s", licErr.Status, licErr.Detail) | ||
| } | ||
| if licErr.IsUnsupportedTag { | ||
| licErr.Message = config.UnsupportedTagMessage() |
Collaborator
There was a problem hiding this comment.
issue: it's unusual to mutate an error message. Can we wrap the error instead?
Collaborator
Author
There was a problem hiding this comment.
went with this approach to avoid a future circular dependancy: 0830aa9. will address now. Thanks for checking 🙏
anisaoshafi
force-pushed
the
devx-859-improve-error-message-for-invalid-image-tags
branch
from
6415826 to
463b358
Compare
anisaoshafi
deleted the
devx-859-improve-error-message-for-invalid-image-tags
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We don't validate the version tag in config.toml so users discover later in the flow some tags are not possible.
Also the error message was not pointing to the real issue.
Changes
licensing.license.formatbody, the error now says "unsupported image tag" instead of the generic token/subscription message, which is more actionable for the user.a) Before // inaccurate message
b) Now: tag="3.99.99" // valid tag regex, but does't exist: license server complains
c) Now: tag="2026.04" // valid tag, previously failed with error a)
