Skip to content

fix: correct port binding for non-default ports #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anisaoshafi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: correct port binding for non-default ports #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78d2e6d
fix: pass GATEWAY_LISTEN env var for non-default ports
anisaoshafi Mar 12, 2026
ce6eef2
add test
anisaoshafi Mar 12, 2026
62517d3
Refactor
anisaoshafi Mar 12, 2026
4a6b0e9
Nit
anisaoshafi Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/runtime/docker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,12 @@ func (d *DockerRuntime) PullImage(ctx context.Context, imageName string, progres
return nil
}

const emulatorContainerPort = nat.Port("4566/tcp")
Copy link
Collaborator

@carole-lavillonniere carole-lavillonniere Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: ultimately, when we support other emulators, we will to configure it per emulator and might want to move this value to runtime.ContainerConfig, but we can do it later!


func (d *DockerRuntime) Start(ctx context.Context, config ContainerConfig) (string, error) {
port := nat.Port(config.Port + "/tcp")
exposedPorts := nat.PortSet{port: struct{}{}}
portBindings := nat.PortMap{port: []nat.PortBinding{{HostPort: config.Port}}}
containerPort := emulatorContainerPort
exposedPorts := nat.PortSet{containerPort: struct{}{}}
portBindings := nat.PortMap{containerPort: []nat.PortBinding{{HostPort: config.Port}}}

resp, err := d.client.ContainerCreate(ctx,
&container.Config{
Expand Down
26 changes: 26 additions & 0 deletions test/integration/start_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ package integration_test
import (
"context"
"net"
"os"
"path/filepath"
"testing"

"github.com/docker/docker/api/types/container"
Expand Down Expand Up @@ -95,6 +97,30 @@ func TestStartCommandFailsWhenPortInUse(t *testing.T) {
assert.Contains(t, stdout, "lstk stop")
}

func TestStartCommandSucceedsWithNonDefaultPort(t *testing.T) {
requireDocker(t)
_ = env.Require(t, env.AuthToken)

cleanup()
t.Cleanup(cleanup)

mockServer := createMockLicenseServer(true)
defer mockServer.Close()

configContent := `
[[containers]]
type = "aws"
tag = "latest"
port = "4567"
`
configFile := filepath.Join(t.TempDir(), "config.toml")
require.NoError(t, os.WriteFile(configFile, []byte(configContent), 0644))

ctx := testContext(t)
_, stderr, err := runLstk(t, ctx, "", env.With(env.APIEndpoint, mockServer.URL), "--config", configFile, "start")
require.NoError(t, err, "lstk start failed: %s", stderr)
}

func cleanup() {
ctx := context.Background()
_ = dockerClient.ContainerStop(ctx, containerName, container.StopOptions{})
Expand Down
Loading