set local domain name to localhost.localstack.cloud to match certificate

Author: whummer

src/main/java/cloud/localstack/Constants.java

@@ -6,6 +6,8 @@
 public class Constants {
     public static final Map<String, Integer> DEFAULT_PORTS = new HashMap<>();
 
+    public static final String LOCALHOST_DOMAIN_NAME = "localhost.localstack.cloud";
+
     static {
         DEFAULT_PORTS.put("apigateway", 4567);
         DEFAULT_PORTS.put("kinesis", 4568);

src/main/java/cloud/localstack/Localstack.java

@@ -1,5 +1,6 @@
 package cloud.localstack;
 
+import cloud.localstack.Constants;
 import cloud.localstack.ServiceName;
 import cloud.localstack.docker.*;
 import cloud.localstack.docker.command.*;
@@ -110,12 +111,12 @@ private void loadServiceToPortMap() {
     public String getEndpointS3() {
         String s3Endpoint = endpointForService(ServiceName.S3);
         /*
-         * Use the domain name wildcard *.localhost.atlassian.io which maps to 127.0.0.1
+         * Use the domain name wildcard *.localhost.localstack.cloud which maps to 127.0.0.1
          * We need to do this because S3 SDKs attempt to access a domain <bucket-name>.<service-host-name>
          * which by default would result in <bucket-name>.localhost, but that name cannot be resolved
          * (unless hardcoded in /etc/hosts)
          */
-        s3Endpoint = s3Endpoint.replace("localhost", "test.localhost.atlassian.io");
+        s3Endpoint = s3Endpoint.replace("localhost", Constants.LOCALHOST_DOMAIN_NAME);
         return s3Endpoint;
     }
 

src/main/java/cloud/localstack/deprecated/Localstack.java

@@ -125,12 +125,12 @@ public static String getEndpointS3() {
     public static String getEndpointS3(boolean overrideSSL) {
         String s3Endpoint = ensureInstallationAndGetEndpoint(ServiceName.S3, overrideSSL);
         /*
-         * Use the domain name wildcard *.localhost.atlassian.io which maps to 127.0.0.1
+         * Use the domain name wildcard *.localhost.localstack.cloud which maps to 127.0.0.1
          * We need to do this because S3 SDKs attempt to access a domain <bucket-name>.<service-host-name>
          * which by default would result in <bucket-name>.localhost, but that name cannot be resolved
          * (unless hardcoded in /etc/hosts)
          */
-        s3Endpoint = s3Endpoint.replace("localhost", "test.localhost.atlassian.io");
+        s3Endpoint = s3Endpoint.replace("localhost", Constants.LOCALHOST_DOMAIN_NAME);
         return s3Endpoint;
     }