add test to assert EntityAlreadyExistsException for IAM roles

Author: whummer

Makefile

@@ -10,6 +10,6 @@ publish-maven:   ## Publish artifacts to Maven Central
 	ADDITIONAL_MVN_TARGETS=deploy ADDITIONAL_MVN_ARGS=" " make build
 
 test:            ## Run tests for Java/JUnit compatibility
-	USE_SSL=1 SERVICES=serverless,kinesis,sns,sqs,cloudwatch mvn $(MVN_ARGS) test
+	USE_SSL=1 SERVICES=serverless,kinesis,sns,sqs,iam,cloudwatch mvn $(MVN_ARGS) test
 
 .PHONY: usage clean install test

src/main/java/cloud/localstack/Localstack.java

@@ -195,6 +195,10 @@ public String getEndpointStepFunctions() {
         return endpointForService(ServiceName.STEPFUNCTIONS);
     }
 
+    public String getEndpointIAM() {
+        return endpointForService(ServiceName.IAM);
+    }
+
     public String endpointForService(String serviceName) {
         if (serviceToPortMap == null) {
             throw new IllegalStateException("Service to port mapping has not been determined yet.");

src/main/java/cloud/localstack/ServiceName.java

@@ -21,5 +21,5 @@ public class ServiceName {
     public static final String SECRETSMANAGER = "secretsmanager";
     public static final String STEPFUNCTIONS = "stepfunctions";
     public static final String EC2 = "ec2";
-
+    public static final String IAM = "iam";
 }

src/main/java/cloud/localstack/TestUtils.java

@@ -12,6 +12,8 @@
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDBClientBuilder;
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDBStreams;
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDBStreamsClientBuilder;
+import com.amazonaws.services.identitymanagement.AmazonIdentityManagement;
+import com.amazonaws.services.identitymanagement.AmazonIdentityManagementClientBuilder;
 import com.amazonaws.services.kinesis.AmazonKinesis;
 import com.amazonaws.services.kinesis.AmazonKinesisAsync;
 import com.amazonaws.services.kinesis.AmazonKinesisAsyncClientBuilder;
@@ -175,6 +177,16 @@ public static AmazonCloudWatch getClientCloudWatch() {
                 withCredentials(getCredentialsProvider()).build();
     }
 
+    public static AmazonIdentityManagement getClientIAM() {
+        return AmazonIdentityManagementClientBuilder.standard().
+                withEndpointConfiguration(getEndpointConfigurationIAM()).
+                withCredentials(getCredentialsProvider()).build();
+    }
+
+    protected static AwsClientBuilder.EndpointConfiguration getEndpointConfigurationIAM() {
+        return getEndpointConfiguration(Localstack.INSTANCE.getEndpointIAM());
+    }
+
     protected static AwsClientBuilder.EndpointConfiguration getEndpointConfigurationLambda() {
         return getEndpointConfiguration(Localstack.INSTANCE.getEndpointLambda());
     }

src/main/java/cloud/localstack/docker/Container.java

@@ -22,7 +22,7 @@ public class Container {
     private static final Logger LOG = Logger.getLogger(Container.class.getName());
 
     private static final String LOCALSTACK_NAME = "localstack/localstack";
-    private static final String LOCALSTACK_PORTS = "4567-4584";
+    private static final String LOCALSTACK_PORTS = "4566-4593";
 
     private static final int MAX_PORT_CONNECTION_ATTEMPTS = 10;
 
@@ -92,13 +92,11 @@ public static Container getRunningLocalstackContainer(String containerId) {
         return new Container(containerId, portMappingsList);
     }
 
-
     private Container(String containerId, List<PortMapping> ports) {
         this.containerId = containerId;
         this.ports = Collections.unmodifiableList(ports);
     }
 
-
     /**
      * Given an internal port, retrieve the publicly addressable port that maps to it
      */
@@ -110,12 +108,10 @@ public int getExternalPortFor(int internalPort) {
                 .orElseThrow(() -> new IllegalArgumentException("Port: " + internalPort + " does not exist"));
     }
 
-
     public void waitForAllPorts(String ip) {
         ports.forEach(port -> waitForPort(ip, port));
     }
 
-
     private void waitForPort(String ip, PortMapping port) {
         int attempts = 0;
         do {
@@ -129,7 +125,6 @@ private void waitForPort(String ip, PortMapping port) {
         throw new IllegalStateException("Could not open port:" + port.getExternalPort() + " on ip:" + port.getIp());
     }
 
-
     private boolean isPortOpen(String ip, PortMapping port) {
         try (Socket socket = new Socket()) {
             socket.connect(new InetSocketAddress(ip, port.getExternalPort()), 1000);
@@ -139,7 +134,6 @@ private boolean isPortOpen(String ip, PortMapping port) {
         }
     }
 
-
     /**
      * Poll the docker logs until a specific token appears, then return. Primarily
      * used to look for the "Ready." token in the LocalStack logs.
@@ -159,18 +153,15 @@ public void waitForLogToken(Pattern pattern) {
         throw new IllegalStateException("Could not find token: " + pattern + " in Docker logs: " + logs);
     }
 
-
     private boolean logContainsPattern(Pattern pattern) {
         String logs = getContainerLogs();
         return pattern.matcher(logs).find();
     }
 
-
     private String getContainerLogs() {
         return new LogCommand(containerId).withNumberOfLines(NUM_LOG_LINES).execute();
     }
 
-
     private void waitForLogs(){
         try {
             Thread.sleep(POLL_INTERVAL);
@@ -180,7 +171,6 @@ private void waitForLogs(){
         }
     }
 
-
     /**
      * Stop the container
      */
@@ -192,7 +182,6 @@ public void stop() {
         LOG.info("Stopped container: " + containerId);
     }
 
-
     /**
      * Run a command on the container via docker exec
      */

src/test/java/cloud/localstack/docker/BasicDockerFunctionalityTest.java

@@ -9,6 +9,9 @@
 import com.amazonaws.auth.AWSStaticCredentialsProvider;
 import com.amazonaws.services.cloudwatch.*;
 import com.amazonaws.services.cloudwatch.model.*;
+import com.amazonaws.services.identitymanagement.AmazonIdentityManagement;
+import com.amazonaws.services.identitymanagement.model.CreateRoleRequest;
+import com.amazonaws.services.identitymanagement.model.EntityAlreadyExistsException;
 import com.amazonaws.services.dynamodbv2.AmazonDynamoDB;
 import com.amazonaws.services.dynamodbv2.model.AttributeDefinition;
 import com.amazonaws.services.dynamodbv2.model.CreateTableRequest;
@@ -203,6 +206,20 @@ public void testCloudWatch() throws Exception {
         Assert.assertNotNull(response);
     }
 
+    @org.junit.Test
+    @org.junit.jupiter.api.Test
+    public void testCreateDuplicateRoleException() {
+        AmazonIdentityManagement iamClient = TestUtils.getClientIAM();
+        try {
+            CreateRoleRequest request = new CreateRoleRequest().withRoleName("role1234");
+            iamClient.createRole(request);
+            iamClient.createRole(request);
+            throw new RuntimeException("EntityAlreadyExistsException should be thrown");
+        } catch (EntityAlreadyExistsException e) {
+            // this exception is expected here
+        }
+    }
+
     private SQSConnection createSQSConnection() throws Exception {
         SQSConnectionFactory connectionFactory = SQSConnectionFactory.builder().withEndpoint(
                 Localstack.INSTANCE.getEndpointSQS()).withAWSCredentialsProvider(