-
Notifications
You must be signed in to change notification settings - Fork 44
chore(deps): bump urllib3 from 1.26.12 to 2.6.3 #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,5 +5,5 @@ lob==4.5.4 | |
| python-dateutil==2.8.2 | ||
| requests==2.28.1 | ||
| six==1.16.0 | ||
| urllib3==1.26.12 | ||
| urllib3==2.6.3 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. urllib3 2.x incompatible with Python 3.7 test matrixHigh Severity The |
||
| python-dotenv>=0.21.0 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urllib3 2.x incompatible with pinned requests 2.28.1
High Severity
Upgrading
urllib3from 1.26.12 to 2.6.3 introduces a compatibility issue with the pinnedrequests==2.28.1dependency. The requests library didn't add support for urllib3 2.x until version 2.31.0 or later. When requests 2.28.1 attempts to use urllib3 2.x at runtime, it will fail due to breaking API changes in the major version upgrade. Bothrequestsandurllib3need to be upgraded together for compatibility.Additional Locations (1)
requirements.txt#L5-L6