Skip to content

FD-672: Upgrade Node.js from v20 to v24#534

Merged
KARSE22 merged 2 commits into
mainfrom
chore/FD-672/node-upgrade-24
May 29, 2026
Merged

FD-672: Upgrade Node.js from v20 to v24#534
KARSE22 merged 2 commits into
mainfrom
chore/FD-672/node-upgrade-24

Conversation

@KARSE22
Copy link
Copy Markdown
Contributor

@KARSE22 KARSE22 commented May 29, 2026

Summary

  • Bumps Node.js from v20.18.1 to v24.15.0 across all environments
  • Adds actions/setup-node@v4 to ci.yml and cd.yml (these were missing it; deploy.yml already had it)
  • Updates Dockerfile to node:24-alpine (floating tag so OS security patches apply automatically)
  • Updates package.json engines to >=24.0.0
  • Fixes a pre-existing deprecated set-output command in cd.yml → uses $GITHUB_OUTPUT

@KARSE22 KARSE22 requested a review from a team as a code owner May 29, 2026 18:30
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js version from 20 to 24 across the project, including the .node-version file, the contract tests Dockerfile, and the package configuration files. The reviewer recommends pinning the Docker base image to the exact Node.js version (24.15.0-alpine) instead of using a floating tag to ensure build consistency and reproducibility.

Comment thread actions/contract_tests/Dockerfile Outdated
@guardrails
Copy link
Copy Markdown

guardrails Bot commented May 29, 2026

⚠️ We detected 19 security issues in this pull request:

Insecure Access Control (1)
Severity Details Docs
High Title: Missing User Instruction
FROM node:24.15.0-alpine
📚

More info on how to fix Insecure Access Control in Dockerfile.


Vulnerable Libraries (18)
Severity Details
High pkg:npm/css-minimizer-webpack-plugin@4.2.2 (t) upgrade to: > 4.2.2
Critical pkg:npm/redoc-cli@0.13.21 (t) upgrade to: > 0.13.21
Medium pkg:npm/css-loader@6.11.0 (t) upgrade to: > 6.11.0
Medium pkg:npm/yaml@2.4.2 (t) upgrade to: 2.8.3,1.10.3
Critical pkg:npm/@stoplight/prism-cli@4.14.1 (t) upgrade to: > 4.14.1
N/A pkg:npm/ajv@8.13.0 (t) upgrade to: 8.18.0
Critical pkg:npm/sass@1.77.2 (t) upgrade to: > 1.77.2
High pkg:npm/webpack-cli@4.10.0 (t) upgrade to: > 4.10.0
Informational pkg:npm/mini-css-extract-plugin@2.9.0 (t) upgrade to: > 2.9.0
High pkg:npm/patch-package@6.5.1 (t) upgrade to: > 6.5.1
Critical pkg:npm/@redocly/cli@1.12.2 (t) upgrade to: > 1.12.2
High pkg:npm/@actions/core@1.10.1 (t) upgrade to: > 1.10.1
High pkg:npm/ava@4.3.3 (t) upgrade to: > 4.3.3
Critical pkg:npm/@slack/web-api@6.12.0 (t) upgrade to: > 6.12.0
High pkg:npm/openapi-to-postmanv2@3.2.1 (t) upgrade to: > 3.2.1
Critical pkg:npm/@stoplight/spectral-cli@6.11.1 (t) upgrade to: > 6.11.1
Low pkg:npm/webpack@5.91.0 (t) upgrade to: 5.104.0
High pkg:npm/webpack-dev-server@4.15.2 (t) upgrade to: 5.2.4

More info on how to fix Vulnerable Libraries in JavaScript.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

- Bump .node-version to 24.15.0
- Update package.json engines to >=24.0.0
- Update Dockerfile to node:24-alpine (floating tag for OS patches)
- Add actions/setup-node@v4 step to ci.yml and cd.yml
- Fix deprecated set-output command in cd.yml to use GITHUB_OUTPUT
@KARSE22 KARSE22 force-pushed the chore/FD-672/node-upgrade-24 branch from a97d311 to 926c467 Compare May 29, 2026 18:31
Copy link
Copy Markdown
Contributor

@kevinpjones kevinpjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, FWIW

@KARSE22 KARSE22 merged commit 3c5cc5d into main May 29, 2026
4 of 5 checks passed
@KARSE22 KARSE22 deleted the chore/FD-672/node-upgrade-24 branch May 29, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants