Change CheckEditable.amount to Double
#345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why did you close this? i just got bit by it as well |
hpelletier
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #346
Floattoo imprecise for this field, and when serialized the value can materially change:We should at least change the type to
Double, though I would prefer to change this field toBigDecimal- let me know if that is workable (not sure why floating point types were originally chosen for this and understand there may be constraints I'm not aware of).Note I did not do any OpenApi generation because I couldn't get it to work correctly and I wasn't able to find any documentation. Even when using version 5.3.0, the changes it made by the generator were way beyond the scope of what I'm trying to do. If this is required, please let me know the proper way to do the generation.