Fix: Restore 'buying' and 'selling' locales lost in pr #770

[Luquitasjeffrey]

Closes #812
Fixes the regression introduced in #770 in which the "buying" and "selling" translation entries were deleted, but keep being in the order creation wizzard

Summary by CodeRabbit

• Localization
  • Added multilingual support for "Selling" and "Buying" trade-type labels across 10 languages including English, German, Spanish, French, Italian, Portuguese, Russian, Ukrainian, Korean, and Persian. Users now have access to consistent, localized terminology for trade operations throughout the application.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 61e3dad7-52a3-41b9-886a-6ecdd709faa2

📥 Commits

Reviewing files that changed from the base of the PR and between d2c5b57 and 6d2675e.

📒 Files selected for processing (10)

• locales/de.yaml
• locales/en.yaml
• locales/es.yaml
• locales/fa.yaml
• locales/fr.yaml
• locales/it.yaml
• locales/ko.yaml
• locales/pt.yaml
• locales/ru.yaml
• locales/uk.yaml

---

Walkthrough

This PR adds two new translation keys, selling and buying, across all ten locale files (German, English, Spanish, Farsi, French, Italian, Korean, Portuguese, Russian, and Ukrainian). Each locale receives language-appropriate verb forms for these generic trade-type labels.

Changes

Generic trade-type labels localization

Layer / File(s)

Summary

Selling and buying labels across all locales locales/de.yaml, locales/en.yaml, locales/es.yaml, locales/fa.yaml, locales/fr.yaml, locales/it.yaml, locales/ko.yaml, locales/pt.yaml, locales/ru.yaml, locales/uk.yaml

Two new i18n keys selling and buying are uniformly added across all supported locale files with language-appropriate translations for each: German "Verkaufe"/"Kaufe", English "Selling"/"Buying", Spanish "Vendiendo"/"Comprando", Farsi "فروختن"/"خریدن", French "Vente"/"Achat", Italian "Vendita"/"Acquisto", Korean "팝니다"/"삽니다", Portuguese "Vendendo"/"Comprando", Russian "Продаю"/"Покупаю", and Ukrainian "Продаю"/"Купую".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• lnp2pBot/bot#770: Introduces selling_sats/buying_sats variants and related showusername_* keys that build on these generic trade-type labels.

Suggested reviewers

• mostronatorcoder

Poem

🐰 Through languages far and wide,
Selling, buying side by side,
Keys aligned with every tongue,
A harmony in translation sung!
i18n grows strong. ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	All changes are scoped to locale files only, directly addressing the missing translation keys without modifying messages.ts or other code.	Issue #812 proposes updating messages.ts to use 'selling_sats'/'buying_sats' instead of restoring 'selling'/'buying' keys. Clarify which approach is intended or update messages.ts accordingly.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes restoring 'buying' and 'selling' locales, which matches the changeset across all locale files.
Linked Issues check	✅ Passed	The PR adds 'buying' and 'selling' keys to all locale files, directly addressing issue #812's root cause of missing locale entries.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue812

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}