Skip to content

Fix image conversion state handling across formats #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmanuel-ferdman wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −8
Open

Fix image conversion state handling across formats #3718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions fastchat/serve/vision/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,30 @@ def convert_image_to_base64(self):
from PIL import Image
import requests

image_bytes = BytesIO()

# Load image if it has not been loaded in yet
if self.image_format == ImageFormat.URL:
response = requests.get(image)
response = requests.get(self.url)
image = Image.open(BytesIO(response.content)).convert("RGBA")
image_bytes = BytesIO()
image.save(image_bytes, format="PNG")
elif self.image_format == ImageFormat.LOCAL_FILEPATH:
image = Image.open(self.url).convert("RGBA")
image_bytes = BytesIO()
image.save(image_bytes, format="PNG")
elif self.image_format == ImageFormat.BYTES:
image_bytes = image
image_data = base64.b64decode(self.base64_str)
image = Image.open(BytesIO(image_data)).convert("RGBA")
else:
raise ValueError(f"Unsupported image format: {self.image_format}")

img_b64_str = base64.b64encode(image_bytes).decode()
image.save(image_bytes, format="PNG")
img_b64_str = base64.b64encode(image_bytes.getvalue()).decode()

return img_b64_str

def to_openai_image_format(self):
if self.image_format == ImageFormat.URL: # input is a url
return self.url
elif self.image_format == ImageFormat.LOCAL_FILEPATH: # input is a local image
self.base64_str = self.convert_image_to_base64(self.url)
self.base64_str = self.convert_image_to_base64()
return f"data:image/{self.filetype};base64,{self.base64_str}"
elif self.image_format == ImageFormat.BYTES:
return f"data:image/{self.filetype};base64,{self.base64_str}"
Expand Down