Skip to content

fix: type mis-match between Context and model list #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
congchan wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −9
Open

fix: type mis-match between Context and model list #3687

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce42c70
fix: type mis-match of Context and model list
congchan Feb 23, 2025
d4c3b0c
reformat by pylint
congchan Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions fastchat/serve/gradio_web_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,21 +252,14 @@ def get_model_list(controller_url, register_api_endpoint_file, vision_arena):
return visible_models, models


def load_demo_single(context: Context, query_params):
# default to text models
models = context.text_models

def load_demo_single(models, query_params):
selected_model = models[0] if len(models) > 0 else ""
if "model" in query_params:
model = query_params["model"]
if model in models:
selected_model = model

all_models = context.models

dropdown_update = gr.Dropdown(
choices=all_models, value=selected_model, visible=True
)
dropdown_update = gr.Dropdown(choices=models, value=selected_model, visible=True)
state = None
return [state, dropdown_update]

Expand Down