Clean Upvote and Downvote data #3611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Will grab all the upvotes. |
infwinston
reviewed
Nov 9, 2024
Member
infwinston
left a comment
infwinston
left a comment
There was a problem hiding this comment.
Thanks @CodingWithTim left some comments
Collaborator
Author
|
@infwinston Suggestions integrated. |
infwinston
reviewed
Nov 10, 2024
Member
infwinston
left a comment
infwinston
left a comment
There was a problem hiding this comment.
a critical thing should be fixed. chunk_size shouldn't be 1 otherwise we will introduce lots of overhead and it might be even slower than sequential implementation.
infwinston
reviewed
Nov 10, 2024
infwinston
reviewed
Nov 11, 2024
infwinston
approved these changes
Nov 13, 2024
Comment on lines
158
to
167
| # Aggregate results from child processes | ||
| ct_invalid_conv_id = sum( | ||
| [data["ct_invalid_conv_id"] for data in results if "ct_invalid_conv_id" in data] | ||
| ) | ||
| ct_invalid = sum([data["ct_invalid"] for data in results if "ct_invalid" in data]) | ||
| ct_network_error = sum( | ||
| [data["ct_network_error"] for data in results if "ct_network_error" in data] | ||
| ) | ||
| all_models = set([data["model"] for data in results if "model" in data]) | ||
| chats = [data["result"] for data in results if "result" in data] |
Member
There was a problem hiding this comment.
Can we merge into one for loop?
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number (if applicable)
Checks
format.shto lint the changes in this PR.