cmd: import hostlist module, bump version#37
Open
cmoussa1 wants to merge 2 commits intollnl:masterfrom
Open
Conversation
Problem: Building the hostlist package with the commands listed in the start page does not allow for actual use of any of the 'hostlist *' commands and instead raises an AttributeError complaining that it can't find any of the functions. Add the import of the hostlist package to __init__.py so that the command-line interface can actually utilize the functions defined in hostlist.py and a user can run things like 'hostlist -e node[1-4]' instead of 'python cla_hostlist.py -e node[1-4]'. Bump the version of py-hostlist to 0.1.0.
Problem: The test installation of the hostlist package explicitly specifies the version number of the hostlist package, but this will no longer apply when the version number is bumped up. Change the "pip install" command to instead just use a wildcard so that we don't have to change the name of the package every time the version number is bumped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building the
hostlistpackage with the commands listed in the start page does not allow for actual use of any of thehostlistcommands and instead raises anAttributeErrorcomplaining that it can't find any of the functions.This PR adds the import of the
hostlistpackage to__init__.pyso that the command-line interface can actually utilize the functions defined inhostlist.pyand a user can run things likehostlist -e node[1-4]instead ofpython cla_hostlist.py -e node[1-4].It also bumps the version of the py-hostlist package to
0.1.0.