Skip to content

Minor Annotation Code Clean-up #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LRWeber merged 1 commit into from
Dec 2, 2025
Merged

Minor Annotation Code Clean-up #730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions assets/js/visualize/line_repoActivity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,6 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
.nice();

var dToday = x.domain()[1];
// Supercomputing
var dSupercomp = '11-18';
// Thanksgiving
var dThnxgiv = '11-25';
// Christmas
var dXmas = '12-25';

function addDateLine(dateString, label) {
var dateObj = getYearDate(dateString, dToday);
Expand Down Expand Up @@ -160,9 +154,15 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
.attr('d', valueline);

// Draw date-of-interest reference lines
addDateLine(dSupercomp, 'Supercomputing');
addDateLine(dThnxgiv, 'Thanksgiving');
addDateLine(dXmas, 'Christmas');
var annotationDates = {
'Supercomputing': '11-18',
'Thanksgiving': '11-25',
'Christmas': '12-25'
};
for (var annotationName in annotationDates) {
var annotationDate = annotationDates[annotationName];
addDateLine(annotationDate, annotationName);
}

// Draw dots
chart
Expand Down
28 changes: 14 additions & 14 deletions assets/js/visualize/line_repoActivityExplore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
element = document.querySelector('.' + areaID).parentNode,
containerWidth = element.offsetWidth,
width = containerWidth - margin.left - margin.right,
height = Math.max(containerWidth / 3, 400) - margin.top - margin.bottom;
height = Math.max(containerWidth / 3, 400) - margin.top - margin.bottom;
var dotRadius = stdDotRadius;

var x = d3
Expand Down Expand Up @@ -86,7 +86,7 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
}
return '<sub>[Week of ' + formatTime(d.date) + ']</sub>' + '<br>' + d.value + repos;
});

var pieTip = d3
.tip()
.attr('class', 'd3-tip')
Expand All @@ -96,14 +96,8 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
});

var dToday = x.domain()[1];
// Supercomputing
var dSupercomp = '11-18';
// Thanksgiving
var dThnxgiv = '11-25';
// Christmas
var dXmas = '12-25';

function update(x, y) {

function update(x, y) {
chart.selectAll('g').remove();

var xAxis = d3.axisBottom().scale(x);
Expand Down Expand Up @@ -187,9 +181,15 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {
.attr('d', valueline);

// Draw date-of-interest reference lines
addDateLine(dSupercomp, 'Supercomputing');
addDateLine(dThnxgiv, 'Thanksgiving');
addDateLine(dXmas, 'Christmas');
var annotationDates = {
'Supercomputing': '11-18',
'Thanksgiving': '11-25',
'Christmas': '12-25'
};
for (var annotationName in annotationDates) {
var annotationDate = annotationDates[annotationName];
addDateLine(annotationDate, annotationName);
}

// Draw dots
chart
Expand Down Expand Up @@ -269,7 +269,7 @@ function draw_line_repoActivity(areaID, repoNameWOwner) {

// Colors used for coloring the pie chart
const colors = d3.scaleSequential(d3.interpolate('lightblue', 'white')).domain([0, root.descendants().length]);

// Equivalent of chart but for the pie chart
const pieGroup = chart
.append('g')
Expand Down