lkl: fix default build target to include progs #617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lklfuse, fs2tar and cptofs were accidentally dropped from the default build target via a typo in commit 6d360d1 ("lkl: link tests against common private library"). The install target was still triggering progs-y builds, which is probably why this took longer to notice than expected. Fixes: 6d360d1 ("lkl: link tests against common private library") Signed-off-by: David Disseldorp <ddiss@suse.de>
The previous filter accepted non-usb block devices, which resulted in
unexpected EFI partition mounts. Split the filter and check for
ENV{ID_BUS}!="usb". Tested on systemd-udevd 254 and 257 systems.
Signed-off-by: David Disseldorp <ddiss@suse.de>
Author
|
v2:
|
Author
|
FWIW, the checkpatch failure is due to 13 char abbreviated commit hashes (%h) instead of 12. Mainline checkpatch has been change to accept >=12 hash chars via 6356f18 , so I think it can be ignored. |
ddiss
added a commit
to ddiss/opensuse-kernel
that referenced
this pull request
Nov 13, 2025
lklfuse, fs2tar and cptofs were accidentally dropped from the default
build target via a typo in commit 6d360d164e5d5 ("lkl: link tests
against common private library").
The install target was still triggering progs-y builds, which is
probably why this took longer to notice than expected.
Fixes: 6d360d164e5d5 ("lkl: link tests against common private library")
Signed-off-by: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 191e6381bcf418092644217723001bca7c154c45)
Link: lkl/linux#617
ddiss
added a commit
to ddiss/opensuse-kernel
that referenced
this pull request
Nov 13, 2025
The previous filter accepted non-usb block devices, which resulted in
unexpected EFI partition mounts. Split the filter and check for
ENV{ID_BUS}!="usb". Tested on systemd-udevd 254 and 257 systems.
Signed-off-by: David Disseldorp <ddiss@suse.de>
(cherry picked from commit 101d4a4d0fdd6fe6203831b917ce74bbb7a77fe0)
Link: lkl/linux#617
tavip
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lklfuse, fs2tar and cptofs were accidentally dropped from the default build target via a typo in commit 6d360d1 ("lkl: link tests against common private library").
The install target was still triggering progs-y builds, which is probably why this took longer to notice than expected.
Fixes: 6d360d1 ("lkl: link tests against common private library")