-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add support for Generative Streams (Data-Channel-Only Workflows) #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… implement tests for batched image handling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukiod These changes are looking great! I made a text-to-images type of workflow using Text Renderer and Batch Images nodes for testing to demo how to build generative workflows in comfystream. One small edit was needed to the SaveTensor node to support batched image outputs from workflows like this.
Please review the suggested additions to SaveTensor node which allowed for testing the workflow (link in pr) lukiod#4
feat(tensor_utils): add batched image support to SaveTensor
mergging main
|
@eliteprox i have fixed the threading issue and standardize the image this is the test i run a checking if a 3-D and 4-D PyTorch tensor is passed how will the what save_tensor.py will return this is the testing code i used |

Summary
This PR enables ComfyStream to support Generative Streams (e.g., Text-to-Video workflows) where the client provides prompt data via the WebRTC Data Channel but sends no input video/audio stream.
Previously, the pipeline would halt or fail to initialize without an incoming media stream to drive the clock. This change allows the pipeline to self-drive frame generation in "Generative Mode."
Changes
PrimitiveStringto the list of recognizedtext_inputnodes. This allows workflows usingPrimitiveStringfor prompts to be correctly validated as accepting text input.Impact
Testing
PrimitiveStringdetection works correctly for modality negotiation.