Skip to content

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Apr 11, 2025

Exports the comfystream.pipeline and comfystream.server packages to make the pipeline and metrics usable in other applications

python
import pkgutil
import comfystream
print([name for _, name, _ in pkgutil.iter_modules(comfystream.__path__)])
['client', 'pipeline', 'scripts', 'server', 'tensor_cache', 'utils']

@eliteprox eliteprox force-pushed the feat/refactor-package-export branch 3 times, most recently from dba0c28 to 1bd0a54 Compare April 11, 2025 05:44
@eliteprox eliteprox changed the title refactor comfystream to export server and pipeline refactor(package): comfystream to export server and pipeline Apr 11, 2025
@eliteprox eliteprox force-pushed the feat/refactor-package-export branch from 1bd0a54 to 42c2d15 Compare April 11, 2025 15:28
@eliteprox eliteprox force-pushed the feat/refactor-package-export branch from 42c2d15 to 527346e Compare April 13, 2025 03:36
@eliteprox eliteprox marked this pull request as ready for review April 14, 2025 21:17
@pschroedl pschroedl self-requested a review April 14, 2025 21:44
Copy link

@pschroedl pschroedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can come to a resolution on the import pattern, I will approve.

@pschroedl pschroedl self-requested a review April 15, 2025 15:06
@pschroedl pschroedl dismissed their stale review April 15, 2025 15:08

Previous concerns were addressed.

@eliteprox eliteprox merged commit 10578c4 into main Apr 15, 2025
8 checks passed
@eliteprox eliteprox deleted the feat/refactor-package-export branch April 15, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants