Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595
Resolve domain names in NAT1To1IP and MediaNAT1To1IP config#595jaylim95 wants to merge 1 commit intolivekit:mainfrom
Conversation
Previously, these fields only accepted literal IP addresses via netip.ParseAddr. Add resolveAddrOrHost helper that first tries parsing as a literal IP, then falls back to DNS resolution via net.LookupHost, returning the first IPv4 result. https://claude.ai/code/session_011bUzCCC8jboSXZdeRWM2w4
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
==========================================
- Coverage 65.25% 62.72% -2.53%
==========================================
Files 51 35 -16
Lines 6588 6909 +321
==========================================
+ Hits 4299 4334 +35
- Misses 1915 2152 +237
- Partials 374 423 +49 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dennwc
left a comment
There was a problem hiding this comment.
Thank you! LGTM after CLA is signed!
|
I tried clicking on sign CLA for like 20 times in the last 3 weeks but the status never update... |
|
Let me check. I guess this is because the commit is authored by Claude, not your email. |
Previously, these fields only accepted literal IP addresses via netip.ParseAddr. Added support for DNS resolution when SIP LB does not have a static IP but has a stable domain name.
Added resolveAddrOrHost helper that first tries parsing as a literal IP, then falls back to DNS resolution via net.LookupHost, returning the first IPv4 result.