fix PC timeout when connecting with can_subscribe=false#955
Open
s-hamdananwar wants to merge 4 commits intomainfrom
Open
fix PC timeout when connecting with can_subscribe=false#955s-hamdananwar wants to merge 4 commits intomainfrom
s-hamdananwar wants to merge 4 commits intomainfrom
Conversation
Contributor
|
@s-hamdananwar , nice, could you please use codex or claude to add an unit tests in Rust SDK's peer connection tests ? |
Contributor
Author
|
@xianshijing-lk done ✅ |
xianshijing-lk
approved these changes
Mar 20, 2026
Contributor
|
lgtm, thanks for fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a participant connects with
canSubscribe=falsein their token, the server sendssubscriber_primary=falsein the JoinResponse and does not send a subscriber offer. This results inwait_pc_connectiontiming out as it is expecting a subscriber PC even when the peer connection is publisher primary. This PR will skip waiting for subscriber PC whensubscriber_primary=false.