Skip to content

fix PC timeout when connecting with can_subscribe=false#955

Open
s-hamdananwar wants to merge 4 commits intomainfrom
hamdan/fix-publisher-primary-pc-connection-timeout
Open

fix PC timeout when connecting with can_subscribe=false#955
s-hamdananwar wants to merge 4 commits intomainfrom
hamdan/fix-publisher-primary-pc-connection-timeout

Conversation

@s-hamdananwar
Copy link
Contributor

@s-hamdananwar s-hamdananwar commented Mar 19, 2026

When a participant connects with canSubscribe=false in their token, the server sends subscriber_primary=false in the JoinResponse and does not send a subscriber offer. This results in wait_pc_connection timing out as it is expecting a subscriber PC even when the peer connection is publisher primary. This PR will skip waiting for subscriber PC when subscriber_primary=false.

@xianshijing-lk
Copy link
Contributor

@s-hamdananwar , nice, could you please use codex or claude to add an unit tests in Rust SDK's peer connection tests ?
Ideally, we can verify that things are broken before this PR, and get fixed by this PR.

@s-hamdananwar
Copy link
Contributor Author

@xianshijing-lk done ✅

@xianshijing-lk
Copy link
Contributor

lgtm, thanks for fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants