webrtc-sys-build: disable zip default features#1061
Open
charliermarsh wants to merge 2 commits intolivekit:mainfrom
Open
webrtc-sys-build: disable zip default features#1061charliermarsh wants to merge 2 commits intolivekit:mainfrom
charliermarsh wants to merge 2 commits intolivekit:mainfrom
Conversation
|
|
charliermarsh
force-pushed
the
charlie/drop-zip-default-features
branch
from
d1ab35e to
f25d0b3
Compare
Contributor
|
@charliermarsh, thank you for your contribution. Please add the following changeset at ---
webrtc-sys-build: patch
---
# Disable default features for zip dependency
|
Author
|
Done, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
My understanding is that
webrtc-sys-buildneeds thezipcrate to extract the prebuilt WebRTC archives, which always usedeflate. Trimming the default features removes a significant portion of the dependency tree.