feat(connector-service): update for new protos#1051
Conversation
ChangesetThe following package versions will be affected by this PR:
|
| pub async fn disconnect_whatsapp_call( | ||
| &self, | ||
| call_id: impl Into<String>, | ||
| api_key: impl Into<String>, |
There was a problem hiding this comment.
slight breaking change, should be okay for now because connector is still in beta, but not sure how stuff like this should be handled long term
There was a problem hiding this comment.
if you think there might potentially be more arguments added in the future here it might be worth to replace the reason with a non_exhaustive options struct that allows extending later on
| pub agent_name: String, | ||
| pub metadata: String, | ||
| /// cloud only - matches `JobRestartPolicy` (0 = on failure, 1 = never) | ||
| pub restart_policy: i32, |
There was a problem hiding this comment.
should we declare a new enum here instead?
| /// Optional - Max time for the callee to answer the call | ||
| pub ringing_timeout: Option<Duration>, | ||
| /// Optional - Wait for the answer for the call before returning | ||
| pub wait_until_answered: bool, |
There was a problem hiding this comment.
shouldn't this be an Option<bool> ?
| pub async fn disconnect_whatsapp_call( | ||
| &self, | ||
| call_id: impl Into<String>, | ||
| api_key: impl Into<String>, |
There was a problem hiding this comment.
if you think there might potentially be more arguments added in the future here it might be worth to replace the reason with a non_exhaustive options struct that allows extending later on
2 participants
also update protocol to latest release