Skip to content

fix: type errors with republished event #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidzhao merged 1 commit into from
May 12, 2026
+6 −5
Merged

fix: type errors with republished event #657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions livekit-rtc/livekit/rtc/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,11 +740,12 @@ def _on_room_event(self, event: proto_room.RoomEvent):
# reference continues to see current state, then rekey it
# under the new SID in the participant's publications dict.
previous_sid = event.local_track_republished.previous_sid
lpublication = self.local_participant._track_publications.pop(previous_sid, None)
if lpublication is not None:
lpublication._info = event.local_track_republished.info
self.local_participant._track_publications[lpublication.sid] = lpublication
self.emit("local_track_republished", lpublication, previous_sid)
republished = self.local_participant._track_publications.get(previous_sid)
if republished is not None:
del self.local_participant._track_publications[previous_sid]
republished._info = event.local_track_republished.info
self.local_participant._track_publications[republished.sid] = republished
self.emit("local_track_republished", republished, previous_sid)
elif which == "local_track_subscribed":
sid = event.local_track_subscribed.track_sid
lpublication = self.local_participant.track_publications[sid]
Expand Down
Loading