Conversation
|
boks1971
left a comment
boks1971
left a comment
There was a problem hiding this comment.
don't know all the nuances of egress, but lgtm as far as I could understand
| rpc Close(ClosePlaybackRequest) returns (google.protobuf.Empty); | ||
|
|
||
| // Export a stored replay using egress | ||
| rpc Export(livekit.ExportReplayRequest) returns (livekit.EgressInfo); |
There was a problem hiding this comment.
Are we only going to support this?
I was thinking maybe there is an export faster than real-time by just writing a custom export. Is that an option. If so, maybe rename this to ExportViaEgress?
There was a problem hiding this comment.
I think it's better for that to be completely internal - template and web sources will always be real-time, but if they choose the media source, we can have it export faster
protobufs/livekit_egress.proto
Outdated
| int32 audio_frequency = 7; // (default 44100) | ||
| VideoCodec video_codec = 8; // (default H264_MAIN) | ||
| int32 video_bitrate = 9; // (default 4500) | ||
| int32 video_quality = 12; // quality setting on video encoder |
There was a problem hiding this comment.
deprecate this as it is unused?
| } | ||
|
|
||
| enum SegmentedFileSuffix { | ||
| INDEX = 0; |
There was a problem hiding this comment.
For enums, as these are at package level, we have been doing a acronym prefix. So, for this, it would be SFS_INDEX or something like that.
There was a problem hiding this comment.
keeping these unchanged from v1
biglittlebigben
left a comment
biglittlebigben
left a comment
There was a problem hiding this comment.
This is a valid implementation of you proposal. Can we make sure we gather wide support for the proposal before merging it? I think particularly ask if the robotics (and maybe other backend teams) have any comment as they may have fresher eyes on the API.
4 participants
No description provided.