feat: Add DecodeRTPEndBit for DTMF decoding without Marker bit requirement#46
Merged
dennwc merged 5 commits intolivekit:mainfrom Mar 17, 2026
Merged
Conversation
Contributor
Author
|
:) @dennwc thx |
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
I will defer to the telephony team for feedback on the core of the patch, bur please cleanup the imports before we can consider this. |
Contributor
Author
Resolved |
dennwc
reviewed
Feb 18, 2026
dennwc
reviewed
Feb 24, 2026
… or the DTMF end bit.
ae2ba4b to
98bbcb6
Compare
dennwc
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds DecodeRTPEndBit, an alternative DTMF RTP decoding function that uses the RFC 4733 End bit instead of the Marker bit to determine event completion.
Problem
The existing DecodeRTP requires the RTP Marker bit to be set on incoming DTMF packets. Many SIP providers/gateways do not consistently set the Marker bit (RFC 4733 §2.3.1), causing DTMF events to be silently dropped.
Solution
Added DecodeRTPEndBit as an alternative decoding mode: