Skip to content

Fix WebCamTexture orientation on the wire #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaxHeimbrock merged 2 commits into from
May 7, 2026
Merged

Fix WebCamTexture orientation on the wire #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c809bac
Fix WebCamTexture orientation on the wire
MaxHeimbrock May 7, 2026
d44e453
Adds missing meta file
MaxHeimbrock May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Runtime/Scripts/Internal/TaskYieldInstruction.cs.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 11 additions & 4 deletions Runtime/Scripts/WebCameraSource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,12 @@ protected override VideoRotation GetVideoRotation()
{
switch (CamTexture.videoRotationAngle)
{
case 0: return VideoRotation._0;
case 90: return VideoRotation._90;
case 180: return VideoRotation._0;
case 180: return VideoRotation._180;
case 270: return VideoRotation._270;
}
return VideoRotation._180;
return VideoRotation._0;
}

public WebCameraSource(WebCamTexture texture, VideoBufferType bufferType = VideoBufferType.Rgba) : base(VideoStreamSource.Texture, bufferType)
Expand Down Expand Up @@ -81,8 +83,13 @@ protected override bool ReadBuffer()
}

CamTexture.GetPixels32(_readBuffer);
MemoryMarshal.Cast<Color32, byte>(_readBuffer)
.CopyTo(_captureBuffer.AsSpan());
// GetPixels32 returns rows bottom-up; WebRTC expects top-down. Flip while copying.
var src = MemoryMarshal.Cast<Color32, byte>(_readBuffer);
var dst = _captureBuffer.AsSpan();
int rowBytes = width * GetStrideForBuffer(_bufferType);
for (int y = 0; y < height; y++)
src.Slice(y * rowBytes, rowBytes)
.CopyTo(dst.Slice((height - 1 - y) * rowBytes, rowBytes));

_requestPending = true;

Expand Down
Loading