Fix display pixel density in adaptive stream#1024
Open
hiroshihorie wants to merge 4 commits into
Open
Conversation
VideoView fed its logical (point) frame size straight into UpdateTrackSettings
via adaptiveStreamSize, so on retina/HiDPI displays it under-requested by the
screen scale and the server returned an upscaled/soft layer. Server simulcast/
SVC layers are sized in physical pixels.
- Add VideoView.AdaptiveStreamPixelDensity { auto, fixed(Double) } (capped at
3x), mirroring the JS pixelDensity / Flutter AdaptiveStreamPixelDensity.
- Add a per-view adaptiveStreamPixelDensity property (default .auto).
- Capture the view's own screen scale at performLayout (UIScreen.scale /
NSScreen.backingScaleFactor / traitCollection.displayScale) into State.
- adaptiveStreamSize now returns rendererSize x resolved density (physical px).
Because the scale is read per-view, a track shown on screens with different
scales (e.g. built-in retina + external 1x) requests correctly for each.
hiroshihorie
changed the title
hiroshihorie
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VideoView.AdaptiveStreamPixelDensitywith.autoand.fixed(Double)controlsmaxDensityTesting
swift test --filter AdaptiveStreamPixelDensityTests