Fix SIGBUS in camera capturer on macOS 26#1017
Open
pblazej wants to merge 2 commits into
Open
Conversation
The compiler-synthesized async overload of LKRTCCameraVideoCapturer's start/stopCapture crashes with EXC_BAD_ACCESS on macOS 26 (see #1016). Calling the completion-handler form directly via withCheckedContinuation sidesteps the failing auto-bridge. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS 26, two crash sites in the Swift ↔ ObjC completion-handler bridge hit
EXC_BAD_ACCESSon continuation resume:asyncoverload ofLKRTCCameraVideoCapturer'sstart/stopCapturecrashes; fixed by calling the completion-handler form directly throughwithCheckedContinuation.set(source:enabled:)(#1022) — the@objcMembers-synthesized completion-handler bridge onLocalParticipant.set*crashes; fixed by marking the affectedasyncmethods@nonobjc(same pattern documented onRoom.cleanUp).Closes #1016, #1022.
🤖 Generated with Claude Code