Keep screen share alive across full reconnect#1008
Open
pblazej wants to merge 1 commit into
Open
Conversation
`republishAllTracks()` routes every local track through `unpublish()`, which calls `track.stop()` and tears down the capturer. For iOS broadcast extension and ReplayKit screen capture this kills the IPC and the extension self-terminates — the track gets re-added to the new publisher but no frames flow. Detach screen share publications from the old publisher peer connection without going through `unpublish()` so the capturer keeps running, then let `_publish` reattach it to the new publisher. Resolves #1004 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
WebRTC semantics checkVerified against the libwebrtc tree that reusing the same
Ordering caveat that this fix relies on: Net effect for screen share: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
republishAllTracks()routes every local track throughunpublish(), which callstrack.stop()and tears down the capturer. For iOS broadcast extension and ReplayKit screen capture this closes the IPC and the extension self-terminates — the track gets re-added to the new publisher but no frames flow.unpublish()so the capturer keeps running, then let_publishreattach it to the new publisher.Resolves #1004
Test plan
🤖 Generated with Claude Code