Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/fix-processor-track-restore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Restore original track on sender when processor stopped"
14 changes: 4 additions & 10 deletions lib/src/track/local/local.dart
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ abstract class LocalTrack extends Track {
await _processor!.init(processorOptions);

if (_processor?.processedTrack != null) {
setProcessedTrack(processor.processedTrack!);
await setProcessedTrack(processor.processedTrack!);
}

logger.fine('processor initialized');
Expand All @@ -361,18 +361,12 @@ abstract class LocalTrack extends Track {
if (_processor == null) return;

logger.fine('stopping processor');
await _processor?.processedTrack?.stop();
await _processor?.destroy();
_processor = null;

if (!keepElement) {
// processorElement?.remove();
// processorElement = null;
}

// apply original track constraints in case the processor changed them
//await this._mediaStreamTrack.applyConstraints(this._constraints);
// force re-setting of the mediaStreamTrack on the sender
//await this.setMediaStreamTrack(this._mediaStreamTrack, true);
// Restore original track on sender
await setProcessedTrack(null);

events.emit(TrackProcessorUpdateEvent(track: this));
}
Expand Down
17 changes: 14 additions & 3 deletions lib/src/track/track.dart
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,19 @@ abstract class Track extends DisposableChangeNotifier with EventsEmittable<Track
}

@internal
void setProcessedTrack(rtc.MediaStreamTrack track) {
_originalTrack = _mediaStreamTrack;
_mediaStreamTrack = track;
Future<void> setProcessedTrack(rtc.MediaStreamTrack? track) async {
if (track != null) {
_originalTrack = _mediaStreamTrack;
_mediaStreamTrack = track;
} else if (_originalTrack != null) {
_mediaStreamTrack = _originalTrack!;
_originalTrack = null;
}
// Update sender to transmit the correct track
await sender?.replaceTrack(_mediaStreamTrack);
events.emit(TrackStreamUpdatedEvent(
track: this,
stream: _mediaStream,
));
}
}
Loading