Skip to content

Fix web pre-connect audio buffer sample rate #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hiroshihorie merged 6 commits into from
Feb 26, 2026
Merged

Fix web pre-connect audio buffer sample rate #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b9bb5a
fix web AudioContext suspended state
hiroshihorie Feb 26, 2026
cdca3b3
add changeset
hiroshihorie Feb 26, 2026
0ff48f2
try block
hiroshihorie Feb 26, 2026
78027d9
Merge branch 'main' into hiroshi/fix-web-audio-context-resume
hiroshihorie Feb 26, 2026
9de85e2
fix
hiroshihorie Feb 26, 2026
7d92cd1
changes
hiroshihorie Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changes/fix-web-audio-context-sample-rate
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
patch type="fixed" "Web pre-connect audio buffer using wrong sample rate"
4 changes: 2 additions & 2 deletions lib/src/preconnect/audio_frame_capture_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ class AudioFrameCaptureWeb implements AudioFrameCapture {
final jsTrack = (track as MediaStreamTrackWeb).jsTrack;
final mediaStream = web.MediaStream([jsTrack].toJS);

// 2. Create AudioContext and best-effort resume it because some browsers require a user gesture and may reject or stall resume()
_audioContext = web.AudioContext();
// 2. Create AudioContext at the requested sample rate and best-effort resume it because some browsers require a user gesture and may reject or stall resume()
_audioContext = web.AudioContext(web.AudioContextOptions(sampleRate: sampleRate.toDouble()));
final ctx = _audioContext!;
try {
await ctx.resume().toDart.timeout(const Duration(seconds: 3));
Expand Down