fix(openai,baseten): cancel in-flight TTS syntheses on close()#1439
Merged
Conversation
Wire the TTS-level abortController into synthesize() so close() actually aborts active OpenAI SDK calls and Baseten fetches. Previously the field was dead state and close() was a no-op.
🦋 Changeset detectedLatest commit: e482e82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
toubatbrian
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TTS.close()in the OpenAI and Baseten plugins was a no-op for in-flight syntheses — the class-levelabortControllerwas never wired into the SDK call or fetch, so callingclose()did not cancel active requests.Changes Made
plugins/openai/src/tts.ts: combine caller'sabortSignalwiththis.abortController.signalviaAbortSignal.any()and pass through to the OpenAI SDK call andChunkedStream.plugins/baseten/src/tts.ts: same combined-signal pattern, propagated intoChunkedStream'sfetch.Pre-Review Checklist
Testing